Fix capture of console errors when the register_error_listener option is disabled #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
approved these changes
Jan 26, 2021
Jean85
deleted the
fix-capture-of-console-errors-when-error-listener-is-disabled
branch
|
Thank you. I have it deployed for 7h already and no duplicate event appeared. |
Jean85
pushed a commit
to rjd22/sentry-symfony
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424: I made the
ConsoleErrorListenerlistener configurable via constructor in regards to its ability of logging console errors. It's common in the Symfony world to use Monolog as logging tool, and if both this listener and theMonolog handlerprovided by the main PHP SDK capture the errors then logging will be duplicated.