Replace the use of deprecated getException() by getThrowable() #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already done in #277, since I've added the deprecation handler. Closing as duplicate. |
|
@Jean85, do you have any idea when a new version containing these changes will be released? There have been a lot of commits in the past last two months, without any new released version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getException()onGetResponseForExceptionEventare deprecated since Symfony 4.4.This PR makes sure that
getThrowable()is called instead. We usemethod_exists()to check if this method exists, and otherwise fallback togetException()to keep support for Symfony 4.3 and before.