TracingDriverConnectionFactory calls the deprecated method AbstractMySQLPlatform::getName()

[W0rma]

Environment

• PHP 8.2
• sentry/sentry-symfony:4.8.0

Steps to Reproduce

AbstractMySQLPlatform::getName() was deprecated in doctrine/dbal#4749 but is still used in Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverConnectionFactory.

This triggers the following deprecation warning:

AbstractMySQLPlatform::getName() is deprecated. Identify platforms by their class. (AbstractMySQLPlatform.php:1209 called by TracingDriverConnectionF
actory.php:40, https://github.com/doctrine/dbal/issues/4749, package doctrine/dbal)

Doctrine team suggests to use the class name to identify the platform instead.

As far as I can see the only usage of the platform name is in Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverConnection::getSpanTags().

[Jean85]

Is this a duplicated of #579? In case it would be already fixed in #723

[ste93cry]

No, it isn't. It's a completely different deprecation, which involves the connection class and not the driver class. Actually, I think that the only solution to the problem is to implement a switch that checks the instanceof the platform and returns the expected name for each supported platform, even though it would now be hardcoded and thus less maintainable in the long term.

[ndench]

Would we really need a switch though? We could just use $databasePlatform::class. It just means that the db.system tag would change from mysql to \Doctrine\DBAL\Platforms\MySQL57Platform. Is that a problem?

[ste93cry]

Although not required, I tried to follow as much as possible the guidelines of OpenTelemetry regarding the Connection-level attributes, Since the specification is the best standard out of here in regards to distributed tracing, I think we should continue on this way.

[cleptric]

The list of Sentry's span operations can be found here. It's mandatory to use these, as certain expectations in the product rely on them.

[ste93cry]

We're not talking about span operations, but about span tags 😃

[cleptric]

I see. There is a movement away from creating tags automatically in the SDKs as well, I'll clarify internally. Most likely, we'll move this data to span.data.