Deprecation warning with doctrine/dbal 3.2.0

[Offout]

Environment

sentry/sentry-symfony 4.2.5
doctrine/dbal 3.2.0
Symfony - 5.3, 5.4

Steps to Reproduce

Run any code, look for deprecations warnings

Expected Result

No deprecation warning

Actual Result

The "Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverForV3" class implements "Doctrine\DBAL\VersionAwarePlatformDriver" that is deprecated All drivers will have to be aware of the server version in the next major release.

Why it's happening

doctrine/dbal#4751

[duboiss]

I add the following warning to the issue.

The "Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingServerInfoAwareDriverConnection" class implements "Doctrine\DBAL\Driver\ServerInfoAwareConnection" that is deprecated The methods defined in this interface will be made part of the {@link Driver} interface in the next major release.

[ste93cry]

Please see the referenced issue to understand why it is not possible to solve these deprecations and what's the best solution for the moment

[Jeroeny]

Also:

Deprecated: PDOStatement::bindParam(): Passing null to parameter #4 ($maxLength) of type int is deprecated in Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingStatementForV3::bindParam at line 30

[ste93cry]

I checked the interface for version 3.2 of the DBAL and the $length argument still accepts int|null, so I don't think that the problem is us, but rather who is calling the code 🤔

[Jeroeny]

Indeed, It looks like it might actually be Doctrine calling PDO that causes that one. So unrelated to this issue and repo after all.

Edit: looks like Doctrine passes on the $length parameter if given. Since Sentry always passed $length, even when null, the deprecation can be considered as caused by Sentry. I've made a PR: #586

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[mwansinck]

Could someone please add the label Status: In Progress to prevent this issue from being closed :-)

[weerdenburg]

Can someone of Sentry give an update on this issue?

The "Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverForV3" class implements "Doctrine\DBAL\VersionAwarePlatformDriver" that is deprecated All drivers will have to be aware of the server version in the next major release.

I don't like warnings like this during my test flow's... and even worse, in a next release it will break things!
Please make an appropriate fix for it.

[greg0ire]

Note that implementing that interface results in calls to connect() when calling getDatabasePlatform even if the underlying driver is not versionaware (like sqlite).