Skip to content

fix(replay): Fixes typo in unmask manager #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jul 1, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

Fixes issue were custom masking is reverted on Android

💚 How did you test it?

Manual testing

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Add tests to cover this case

@antonis antonis requested a review from romtsn July 1, 2025 05:31
@antonis antonis marked this pull request as ready for review July 1, 2025 05:36
@antonis antonis requested a review from lucas-zimerman as a code owner July 1, 2025 05:36
@antonis
Copy link
Collaborator Author

antonis commented Jul 1, 2025

The failed E2E tests seem to be related to Appium and will be handled with getsentry/action-app-sdk-overhead-metrics#24

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang, nice catch!

@antonis antonis merged commit 9cbea0a into main Jul 1, 2025
126 of 143 checks passed
@antonis antonis deleted the antonis/fix-android-SRUnmasking branch July 1, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants