Skip to content

fix(ci): Fix variable interpolation in skip-ci workflow #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(ci): Fix variable interpolation in skip-ci workflow #4940

merged 1 commit into from
Jun 23, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jun 23, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes variable interpolation in skip-ci workflow

💡 Motivation and Context

See https://linear.app/getsentry/issue/MOBILE-1001, https://linear.app/getsentry/issue/MOBILE-1002, https://linear.app/getsentry/issue/MOBILE-1003

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis marked this pull request as ready for review June 23, 2025 11:30
@antonis antonis requested a review from lucas-zimerman as a code owner June 23, 2025 11:30
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 464.21 ms 461.32 ms -2.89 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ec2a485 450.84 ms 447.49 ms -3.35 ms
52d9c3f 481.48 ms 468.53 ms -12.95 ms
df5da5d 425.55 ms 432.96 ms 7.41 ms
0e42017 402.23 ms 415.04 ms 12.81 ms
940bd65 466.31 ms 458.52 ms -7.79 ms
f2c6fa5 445.15 ms 449.13 ms 3.98 ms
b4d6bde 425.51 ms 417.37 ms -8.14 ms
1f1c420 403.32 ms 411.98 ms 8.66 ms
6e8a851 425.59 ms 433.51 ms 7.92 ms
bdb324a 422.22 ms 457.88 ms 35.65 ms

App size

Revision Plain With Sentry Diff
ec2a485 17.75 MiB 20.15 MiB 2.40 MiB
52d9c3f 17.75 MiB 20.15 MiB 2.40 MiB
df5da5d 17.75 MiB 20.15 MiB 2.40 MiB
0e42017 17.75 MiB 20.15 MiB 2.40 MiB
940bd65 17.75 MiB 20.15 MiB 2.40 MiB
f2c6fa5 17.75 MiB 20.15 MiB 2.40 MiB
b4d6bde 17.75 MiB 20.15 MiB 2.40 MiB
1f1c420 17.75 MiB 20.15 MiB 2.40 MiB
6e8a851 17.75 MiB 20.15 MiB 2.40 MiB
bdb324a 17.75 MiB 20.15 MiB 2.40 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.82 ms 1224.22 ms 13.40 ms
Size 3.19 MiB 4.35 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1f1c420+dirty 1238.06 ms 1234.04 ms -4.02 ms
ec2a485+dirty 1209.65 ms 1229.18 ms 19.53 ms
f2c6fa5+dirty 1223.47 ms 1227.37 ms 3.90 ms
bdb324a+dirty 1230.02 ms 1226.18 ms -3.84 ms
38a1af2+dirty 1211.57 ms 1219.27 ms 7.70 ms
0e42017+dirty 1235.77 ms 1247.43 ms 11.66 ms
940bd65+dirty 1224.39 ms 1215.57 ms -8.82 ms
b4d6bde+dirty 1218.73 ms 1223.26 ms 4.53 ms
6e8a851+dirty 1222.57 ms 1223.67 ms 1.10 ms
69721ae+dirty 1251.53 ms 1253.69 ms 2.16 ms

App size

Revision Plain With Sentry Diff
1f1c420+dirty 3.19 MiB 4.34 MiB 1.16 MiB
ec2a485+dirty 3.19 MiB 4.35 MiB 1.17 MiB
f2c6fa5+dirty 3.19 MiB 4.35 MiB 1.17 MiB
bdb324a+dirty 3.19 MiB 4.35 MiB 1.17 MiB
38a1af2+dirty 3.19 MiB 4.35 MiB 1.17 MiB
0e42017+dirty 3.19 MiB 4.35 MiB 1.16 MiB
940bd65+dirty 3.19 MiB 4.35 MiB 1.16 MiB
b4d6bde+dirty 3.19 MiB 4.34 MiB 1.16 MiB
6e8a851+dirty 3.19 MiB 4.35 MiB 1.17 MiB
69721ae+dirty 3.19 MiB 4.35 MiB 1.17 MiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.85 ms 407.20 ms -2.65 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ec2a485+dirty 397.67 ms 390.91 ms -6.76 ms
69721ae+dirty 423.63 ms 417.34 ms -6.29 ms
38a1af2+dirty 421.38 ms 431.35 ms 9.97 ms
940bd65+dirty 408.45 ms 419.75 ms 11.30 ms
7d3c3cb+dirty 395.20 ms 413.24 ms 18.04 ms
e12044e+dirty 404.20 ms 398.15 ms -6.06 ms
c352c30+dirty 396.83 ms 378.11 ms -18.72 ms
0e42017+dirty 387.33 ms 399.30 ms 11.97 ms
bdb324a+dirty 401.10 ms 401.16 ms 0.06 ms
1f1c420+dirty 383.31 ms 386.98 ms 3.67 ms

App size

Revision Plain With Sentry Diff
ec2a485+dirty 7.15 MiB 8.42 MiB 1.26 MiB
69721ae+dirty 7.15 MiB 8.42 MiB 1.26 MiB
38a1af2+dirty 7.15 MiB 8.42 MiB 1.26 MiB
940bd65+dirty 7.15 MiB 8.42 MiB 1.26 MiB
7d3c3cb+dirty 7.15 MiB 8.42 MiB 1.26 MiB
e12044e+dirty 7.15 MiB 8.42 MiB 1.26 MiB
c352c30+dirty 7.15 MiB 8.42 MiB 1.26 MiB
0e42017+dirty 7.15 MiB 8.42 MiB 1.26 MiB
bdb324a+dirty 7.15 MiB 8.42 MiB 1.26 MiB
1f1c420+dirty 7.15 MiB 8.42 MiB 1.26 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.85 ms 1236.31 ms 7.46 ms
Size 2.63 MiB 3.79 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8bd8033+dirty 1213.33 ms 1220.88 ms 7.55 ms
0e42017+dirty 1225.89 ms 1231.63 ms 5.74 ms
7d3c3cb+dirty 1226.39 ms 1227.10 ms 0.71 ms
bdb324a+dirty 1229.33 ms 1236.61 ms 7.29 ms
38a1af2+dirty 1210.07 ms 1212.75 ms 2.68 ms
df5da5d+dirty 1235.98 ms 1243.41 ms 7.43 ms
6e8a851+dirty 1227.96 ms 1235.61 ms 7.65 ms
69721ae+dirty 1229.82 ms 1226.00 ms -3.82 ms
c352c30+dirty 1216.60 ms 1231.37 ms 14.77 ms
940bd65+dirty 1216.88 ms 1225.23 ms 8.35 ms

App size

Revision Plain With Sentry Diff
8bd8033+dirty 2.63 MiB 3.78 MiB 1.15 MiB
0e42017+dirty 2.63 MiB 3.78 MiB 1.15 MiB
7d3c3cb+dirty 2.63 MiB 3.78 MiB 1.15 MiB
bdb324a+dirty 2.63 MiB 3.79 MiB 1.15 MiB
38a1af2+dirty 2.63 MiB 3.79 MiB 1.15 MiB
df5da5d+dirty 2.63 MiB 3.78 MiB 1.15 MiB
6e8a851+dirty 2.63 MiB 3.78 MiB 1.15 MiB
69721ae+dirty 2.63 MiB 3.79 MiB 1.15 MiB
c352c30+dirty 2.63 MiB 3.78 MiB 1.15 MiB
940bd65+dirty 2.63 MiB 3.78 MiB 1.15 MiB

lucas-zimerman
lucas-zimerman approved these changes Jun 23, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis merged commit 398e5d0 into main Jun 23, 2025
98 of 99 checks passed
@antonis antonis deleted the antonis/ci-fix-variable-interpolation branch June 23, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @lucas-zimerman