Skip to content

Fix mypy #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2025
Merged

Fix mypy #4649

merged 3 commits into from
Jul 31, 2025

Conversation

sentrivana
Copy link
Contributor

No description provided.

@sentrivana sentrivana marked this pull request as ready for review July 31, 2025 07:59
@sentrivana sentrivana requested a review from a team as a code owner July 31, 2025 07:59
@sentrivana sentrivana enabled auto-merge (squash) July 31, 2025 08:01
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.74%. Comparing base (493ac4b) to head (ffcb201).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4649      +/-   ##
==========================================
- Coverage   80.75%   80.74%   -0.02%     
==========================================
  Files         156      156              
  Lines       16636    16635       -1     
  Branches     2831     2831              
==========================================
- Hits        13435    13432       -3     
  Misses       2312     2312              
- Partials      889      891       +2
Files with missing lines Coverage Δ
sentry_sdk/integrations/openfeature.py 72.72% <100.00%> (+3.16%) ⬆️

... and 1 file with indirect coverage changes

@sentrivana sentrivana mentioned this pull request Jul 31, 2025
Open
adinauer
adinauer approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rlgtm

@sentrivana sentrivana merged commit c1861a3 into master Jul 31, 2025
138 checks passed
@sentrivana sentrivana deleted the ivana/fix-mypy branch July 31, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @adinauer