Skip to content

Fix socket tests to not use example.com #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Conversation

sl0thentr0py
Copy link
Member

part of #4623

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner July 25, 2025 12:26
from tests.conftest import ApproxDict
from tests.conftest import ApproxDict, create_mock_http_server

PORT = create_mock_http_server()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Global HTTP Server Causes Test Isolation Issues

The mock HTTP server is initialized at the module level (PORT = create_mock_http_server()), creating a global, shared resource. This violates test isolation, leading to resource leaks (due to lack of cleanup), potential port conflicts (especially in parallel test execution), and race conditions. The server should be managed within a test fixture for proper setup, teardown, and test isolation.

Locations (1)

Fix in CursorFix in Web

Copy link
Member Author

@sl0thentr0py sl0thentr0py Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional module level

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (69d65db) to head (2b4e96c).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4627      +/-   ##
==========================================
+ Coverage   80.67%   80.69%   +0.01%     
==========================================
  Files         156      156              
  Lines       16510    16510              
  Branches     2806     2806              
==========================================
+ Hits        13320    13322       +2     
+ Misses       2300     2299       -1     
+ Partials      890      889       -1     

see 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) July 25, 2025 13:06
@sl0thentr0py sl0thentr0py merged commit d71b953 into master Jul 25, 2025
138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/faster-test-socket branch July 25, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants