Fix PHP 7.4 deprecations #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please also update the AppVeyor config file to use |
ste93cry
suggested changes
Dec 10, 2019
ste93cry
approved these changes
Dec 10, 2019
|
Any estimated date for this to be released? These deprecation warnings are getting logged on Sentry and it's burning through my events. |
|
Don't take these words as written on stone, but probably tomorrow morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the deprecation handler on a too-low setting, so we missed deprecations under PHP 7.4: https://travis-ci.org/getsentry/sentry-php/jobs/622409178#L330-L345
This fixes them.