Skip to content

ref(samples): improve samples & SPM docs #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 2, 2023
Merged

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Apr 26, 2023

Improves upon the samples and added the sample from #71. Ref: #81

All Android samples are now automatically configured to run in release mode and will automatically upload proguard mapping files.
All iOS samples will automatically upload dsym files.

I've also adjusted the sample from #71 to use SPM and added some docs on how to use SPM instead of Cocoapods.

The run configuration for these samples should also automatically be setup through Android Studio

@buenaflor buenaflor requested a review from marandaneto April 26, 2023 09:05
@buenaflor
Copy link
Contributor Author

buenaflor commented Apr 26, 2023

@marandaneto sry there's a lot of file changed, that's because I had to rearrange and rename the examples.

Most significant changes:

  • README -> adds SPM docs
  • Sample README -> add doc on how to start the samples
  • samples/scripts -> added two shell scripts that prepare the app builds
  • Sentry agp -> added the Sentry AGP to every Android build.gradle.kts for proguard upload
  • Add another sample using SPM (copy pasted the one using cocoapods)

If you have time could you check if the samples work for you now

@marandaneto
Copy link
Contributor

@buenaflor
CI is unhappy.

error: An organization slug is required (provide with --org)

Task :sentry-samples:kmp-app-cocoapods:androidApp:uploadSentryProguardMappingsRelease FAILED

compressing mappings
Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.
uploading mappings
Please attach the full debug log to all bug reports.

@buenaflor
Copy link
Contributor Author

@marandaneto yep, I know where the issue is, I'll get to it

@buenaflor
Copy link
Contributor Author

@marandaneto it's finally green ✅

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @buenaflor

@buenaflor buenaflor merged commit 3d70fab into main May 2, 2023
@buenaflor buenaflor deleted the feat/improve-samples branch May 2, 2023 07:40
@buenaflor buenaflor mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants