-
-
Notifications
You must be signed in to change notification settings - Fork 19
[DRAFT] Add stubs/no-op support for unsupported targets #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
buenaflor
wants to merge
51
commits into
main
Choose a base branch
from
cursor/add-js-browser-target-for-sentry-kmp-235a
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: giancarlo.buenaflor <[email protected]>
…for-sentry-kmp-235a
…s-browser-target-for-sentry-kmp-235a
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- [DRAFT] Add stubs/no-op support for `js` and `wasmJs` target ([#426](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/426)) If none of the above apply, you can opt out of this check by adding |
js
and wasmJs
target
js
and wasmJs
target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Users have bad devex if they use targets that we don't support.
Currently the SDK won't compile and the user would have to shift their sourceSet architecture which is unrealistic.
💡 Motivation and Context
Adds no-op support for js and wasmJs so users can freely use Sentry in the official supported targets and no-op targets.
Closes #328
Closes #327
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps