Skip to content

Add sendDefaultPii option #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 24, 2025
Merged

Add sendDefaultPii option #377

merged 8 commits into from
Apr 24, 2025

Conversation

buenaflor
Copy link
Contributor

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner April 23, 2025 11:40
Copy link
Contributor

github-actions bot commented Apr 23, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 65a3f50

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.92%. Comparing base (08ba98c) to head (65a3f50).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   79.87%   79.92%   +0.04%     
==========================================
  Files          44       44              
  Lines         810      812       +2     
  Branches      108      108              
==========================================
+ Hits          647      649       +2     
  Misses        107      107              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor buenaflor requested a review from kahest April 23, 2025 13:42
@buenaflor buenaflor marked this pull request as draft April 23, 2025 14:26
@buenaflor buenaflor marked this pull request as ready for review April 24, 2025 09:26
@buenaflor buenaflor enabled auto-merge (squash) April 24, 2025 09:35
@buenaflor buenaflor merged commit ad54f19 into main Apr 24, 2025
16 of 17 checks passed
@buenaflor buenaflor deleted the feat/send-default-pii branch April 24, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants