-
-
Notifications
You must be signed in to change notification settings - Fork 19
misc(android): update native android sdk name #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 79.80% 79.82% +0.02%
==========================================
Files 44 44
Lines 807 808 +1
Branches 108 108
==========================================
+ Hits 644 645 +1
Misses 107 107
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM but do/should we have tests for this?
@kahest added tests |
📜 Description
💡 Motivation and Context
Closes #313
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps