Skip to content

misc(android): update native android sdk name #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 4, 2025

Conversation

buenaflor
Copy link
Contributor

📜 Description

💡 Motivation and Context

Closes #313

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner April 3, 2025 22:25
@buenaflor buenaflor changed the title feat(android): update native android sdk name misc(android): update native android sdk name Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (3500fab) to head (ecdd8cf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   79.80%   79.82%   +0.02%     
==========================================
  Files          44       44              
  Lines         807      808       +1     
  Branches      108      108              
==========================================
+ Hits          644      645       +1     
  Misses        107      107              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM but do/should we have tests for this?

@buenaflor
Copy link
Contributor Author

@kahest added tests

@buenaflor buenaflor merged commit 1a49c4d into main Apr 4, 2025
11 checks passed
@buenaflor buenaflor deleted the feat/native-android-sdk-name branch April 4, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report events on Android as sentry.native.android.kotlin-multiplatform
2 participants