Skip to content

Add experimental session replay options to common code #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Sep 27, 2024

📜 Description

replay options

💡 Motivation and Context

Closes #271

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 27, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 473a92f

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.44%. Comparing base (b1d03a2) to head (473a92f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...form/extensions/SentryOptionsExtensions.android.kt 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   75.52%   76.44%   +0.92%     
==========================================
  Files          38       39       +1     
  Lines         576      607      +31     
  Branches       85       86       +1     
==========================================
+ Hits          435      464      +29     
- Misses         96       97       +1     
- Partials       45       46       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review October 1, 2024 15:51
@buenaflor buenaflor requested a review from romtsn as a code owner October 1, 2024 15:51
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@buenaflor buenaflor merged commit 2d92948 into main Oct 8, 2024
11 checks passed
@buenaflor buenaflor deleted the feat/add-replay branch October 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing cinterop for SentrySessionReplayIntegration
2 participants