Skip to content

Make setSentryUnhandledExceptionHook public #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Apr 24, 2024

📜 Description

Makes the setSentryUnhandledExceptionHook api public so users can initialize the iOS SDK themselves and drop the unhandled exceptions created automatically that doesn't have useful information. See here

💡 Motivation and Context

Closes #200

💚 How did you test it?

X

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner April 24, 2024 23:56
@buenaflor buenaflor changed the title Make api public Make setSentryUnhandledExceptionHook public Apr 24, 2024
Copy link

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@buenaflor buenaflor merged commit de163ed into main Apr 30, 2024
@buenaflor buenaflor deleted the enh/make-setupSentryHandle-public branch April 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make setSentryUnhandledExceptionHook public
2 participants