Skip to content

feat(nextjs): Mark errors caught from NextJS wrappers as unhandled #8893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2023
Merged

feat(nextjs): Mark errors caught from NextJS wrappers as unhandled #8893

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44d48da
fix(nextjs): Mark errors from NextJS wrappers as unhandled
Lms24 Aug 29, 2023
cd76e25
add more wrappers/handlers
Lms24 Aug 29, 2023
37e3611
fix linter error
Lms24 Aug 29, 2023
ad4f7b2
Update packages/nextjs/src/common/utils/wrapperUtils.ts
Lms24 Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nextjs/src/common/_error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export async function captureUnderscoreErrorException(contextOrProps: ContextOrP
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'instrument',
handled: true,
handled: false,
data: {
function: '_error.getInitialProps',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/nextjs/src/common/wrapApiHandlerWithSentry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export function withSentry(apiHandler: NextApiHandler, parameterizedRoute?: stri
currentScope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'instrument',
handled: true,
handled: false,
data: {
wrapped_handler: wrappingTarget.name,
function: 'withSentry',
Expand Down