Skip to content

fix(cjs): Use module instead of require for CJS check #15927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix(cjs): Use module instead of require for CJS check #15927

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3d81b3
fix(cjs): Use `module` instead of `require` for CJS check
s1gr1d Mar 31, 2025
01c8374
add additional checks
s1gr1d Mar 31, 2025
1d30f25
remove && module
s1gr1d Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/src/utils/commonjs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/** Detect CommonJS. */
export function isCjs(): boolean {
return typeof require !== 'undefined';
return typeof module !== 'undefined' && typeof module.exports !== 'undefined';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we also checking for module.exports?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some additional safety as there is maybe a variable named module. But it's more unlikely that there is one that is an object with the key exports.

}
Loading