Skip to content

fix(node): Improve OTEL validation logic #13079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(node): Improve OTEL validation logic #13079

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3427777
fix(node): Improve OTEL validation logic
mydea Jul 29, 2024
1550bce
add test
mydea Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/node/src/sdk/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,12 @@ export function validateOpenTelemetrySetup(): void {

const setup = openTelemetrySetupCheck();

const required = ['SentrySpanProcessor', 'SentryContextManager', 'SentryPropagator'] as const;
const required: ReturnType<typeof openTelemetrySetupCheck> = ['SentryContextManager', 'SentryPropagator'];

if (hasTracingEnabled()) {
required.push('SentrySpanProcessor');
}

for (const k of required) {
if (!setup.includes(k)) {
logger.error(
Expand All @@ -206,7 +211,7 @@ export function validateOpenTelemetrySetup(): void {

if (!setup.includes('SentrySampler')) {
logger.warn(
'You have to set up the SentrySampler. Without this, the OpenTelemetry & Sentry integration may still work, but sample rates set for the Sentry SDK will not be respected.',
'You have to set up the SentrySampler. Without this, the OpenTelemetry & Sentry integration may still work, but sample rates set for the Sentry SDK will not be respected. If you use a custom sampler, make sure to use `wrapSamplingDecision`.',
);
}
}
Expand Down
Loading