Skip to content

feat(replay): Improve public Replay APIs #13000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2024
Merged

feat(replay): Improve public Replay APIs #13000

merged 6 commits into from
Jul 24, 2024

Conversation

chargome
Copy link
Member

Improves public Replay methods (start/stop/flush)

Fixes #12810

@chargome chargome self-assigned this Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.31 KB (0%)
@sentry/browser (incl. Tracing) 33.72 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.82 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.16 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.21 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 86.53 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 88.4 KB (+0.01% 🔺)
@sentry/browser (incl. metrics) 26.62 KB (0%)
@sentry/browser (incl. Feedback) 38.98 KB (0%)
@sentry/browser (incl. sendFeedback) 26.93 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.54 KB (0%)
@sentry/react 25.08 KB (0%)
@sentry/react (incl. Tracing) 36.8 KB (0%)
@sentry/vue 26.45 KB (0%)
@sentry/vue (incl. Tracing) 35.61 KB (0%)
@sentry/svelte 22.44 KB (0%)
CDN Bundle 23.52 KB (0%)
CDN Bundle (incl. Tracing) 35.5 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.86 KB (-0.07% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.13 KB (-0.06% 🔽)
CDN Bundle - uncompressed 69 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 105.1 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 216.74 KB (-0.07% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.46 KB (-0.07% 🔽)
@sentry/nextjs (client) 36.66 KB (0%)
@sentry/sveltekit (client) 34.39 KB (0%)
@sentry/node 111.76 KB (0%)
@sentry/node - without tracing 89.21 KB (0%)
@sentry/aws-serverless 98.34 KB (-0.01% 🔽)

@chargome chargome marked this pull request as ready for review July 22, 2024 11:59
@chargome chargome requested a review from a team as a code owner July 22, 2024 11:59
@chargome chargome requested review from mydea and billyvg July 22, 2024 12:15
mydea
mydea approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, great work!

@chargome chargome merged commit 4bdd979 into develop Jul 24, 2024
118 checks passed
@chargome chargome deleted the cg/improve-usability-of-replay-sdk-public-apis branch July 24, 2024 08:21
@aliu39 aliu39 mentioned this pull request Aug 5, 2024
Merged
9 tasks
@angeloreale angeloreale mentioned this pull request Aug 15, 2024
Merged
@q1blue q1blue mentioned this pull request Aug 16, 2024
Open
@wkylin wkylin mentioned this pull request Aug 19, 2024
Closed
@sleidig sleidig mentioned this pull request Aug 21, 2024
Closed
@q1blue q1blue mentioned this pull request Aug 22, 2024
Open
@sleidig sleidig mentioned this pull request Aug 22, 2024
Closed
@angeloreale angeloreale mentioned this pull request Aug 22, 2024
Merged
@q1blue q1blue mentioned this pull request Aug 23, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Aug 23, 2024
Closed
@FengShangWuQi FengShangWuQi mentioned this pull request Aug 25, 2024
Closed
@angeloreale angeloreale mentioned this pull request Aug 25, 2024
Closed
@q1blue q1blue mentioned this pull request Aug 27, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Aug 27, 2024
Closed
@angeloreale angeloreale mentioned this pull request Aug 27, 2024
Merged
@tomwwinter tomwwinter mentioned this pull request Aug 27, 2024
Closed
@gokulk16 gokulk16 mentioned this pull request Aug 28, 2024
Closed
@angeloreale angeloreale mentioned this pull request Aug 28, 2024
Open
@q1blue q1blue mentioned this pull request Aug 28, 2024
Open
@angeloreale angeloreale mentioned this pull request Aug 29, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Aug 30, 2024
Merged
@angeloreale angeloreale mentioned this pull request Aug 30, 2024
Open
@q1blue q1blue mentioned this pull request Aug 30, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 1, 2024
Closed
@PierreGode PierreGode mentioned this pull request Sep 4, 2024
Open
@q1blue q1blue mentioned this pull request Sep 7, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@mydea mydea mydea approved these changes

+1 more reviewer

@c298lee c298lee c298lee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve usability of Replay SDK public APIs (start/stop/flush)
4 participants
@chargome @billyvg @mydea @c298lee