Skip to content

Add end to end tests for our console sample #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 11, 2025

#skip-changelog

📜 Description

  • Add end to end tests for our console sample
  • Replace bash scripts for running e2e tests with a python script
    • also has an interactive mode that asks which modules to run
    • also allows just setting up test systems and then running the tests from IDE for debugging

You can now run system tests locally more easily by executing:

python3 test/system-test-runner.py test -i

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 11, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6fca7ee

Copy link
Contributor

github-actions bot commented Jul 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.08 ms 444.80 ms 18.72 ms
Size 1.58 MiB 2.09 MiB 519.28 KiB

Previous results on branch: feat/e2e-console-app-samples

Startup times

Revision Plain With Sentry Diff
ac946c9 500.50 ms 515.71 ms 15.21 ms
2fe9357 447.49 ms 486.31 ms 38.82 ms
29f60d6 427.43 ms 465.10 ms 37.68 ms
97a4817 373.00 ms 418.60 ms 45.60 ms

App size

Revision Plain With Sentry Diff
ac946c9 1.58 MiB 2.09 MiB 519.04 KiB
2fe9357 1.58 MiB 2.09 MiB 519.04 KiB
29f60d6 1.58 MiB 2.09 MiB 519.27 KiB
97a4817 1.58 MiB 2.09 MiB 519.05 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants