fix: ensure correct signal delivery on multi-client setups#1190
Merged
fix: ensure correct signal delivery on multi-client setups#1190
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
sl0thentr0py
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously logs and metrics were coupled with the sentry.client, this created these problems on multi client setups:
WithCtxon multi client setups, if the passed context/hub was on a new client, the signal was captured on the old client (used on initialization)bindClientwas used on hub, the client which was set wasn't respected.resolveScopeAndTracewas falling back to theCurrentHub. In multi client setups this means that the fallback hub would always be the one from the most recent client, since theInitmethod always binds the new client on theCurrentHub.The PR solves all issues by coupling logs and metrics with the
Huband not theClient. This way we always can fall back to the Hub provided on logger/metric init, rather than a client which may have been mutated withbindClientor theCurrentHubwhich would return the most recent client.Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)