Skip to content

fix: ensure correct signal delivery on multi-client setups#1190

Merged
giortzisg merged 1 commit intomasterfrom
fix/multi-client-delivery
Feb 10, 2026
Merged

fix: ensure correct signal delivery on multi-client setups#1190
giortzisg merged 1 commit intomasterfrom
fix/multi-client-delivery

Conversation

@giortzisg
Copy link
Contributor

Description

Previously logs and metrics were coupled with the sentry.client, this created these problems on multi client setups:

  • when using WithCtx on multi client setups, if the passed context/hub was on a new client, the signal was captured on the old client (used on initialization)
  • if bindClient was used on hub, the client which was set wasn't respected.
  • the resolveScopeAndTrace was falling back to the CurrentHub. In multi client setups this means that the fallback hub would always be the one from the most recent client, since the Init method always binds the new client on the CurrentHub.

The PR solves all issues by coupling logs and metrics with the Hub and not the Client. This way we always can fall back to the Hub provided on logger/metric init, rather than a client which may have been mutated with bindClient or the CurrentHub which would return the most recent client.

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

@giortzisg giortzisg self-assigned this Feb 9, 2026
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Log specific message for RequestEntityTooLarge by giortzisg in #1185

Bug Fixes 🐛

  • Ensure correct signal delivery on multi-client setups by giortzisg in #1190

Internal Changes 🔧

  • (deps) Bump getsentry/craft from 2.19.0 to 2.20.1 by dependabot in #1187
  • Rename Telemetry Processor components by giortzisg in #1186

🤖 This preview updates automatically when you update the PR.

@giortzisg giortzisg merged commit f057a8d into master Feb 10, 2026
18 checks passed
@giortzisg giortzisg deleted the fix/multi-client-delivery branch February 10, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants