fix: scheduler should check for ready to flush buffers#1143
Merged
Conversation
lcian
approved these changes
Nov 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
==========================================
- Coverage 86.81% 86.78% -0.04%
==========================================
Files 62 62
Lines 6092 6092
==========================================
- Hits 5289 5287 -2
- Misses 589 590 +1
- Partials 214 215 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a CPU spike reported issue. The scheduler should idle on cases where there is no work available, but in the previous implementation the check for having work was checking for non empty buffers.
In the case where logs where appended, the scheduler would constantly check for non ready buffers, consuming resources and causing the CPU to spike.