Skip to content

fix: scheduler should check for ready to flush buffers#1143

Merged
giortzisg merged 1 commit intomasterfrom
fix/scheduler
Nov 24, 2025
Merged

fix: scheduler should check for ready to flush buffers#1143
giortzisg merged 1 commit intomasterfrom
fix/scheduler

Conversation

@giortzisg
Copy link
Contributor

Description

This fixes a CPU spike reported issue. The scheduler should idle on cases where there is no work available, but in the previous implementation the check for having work was checking for non empty buffers.

In the case where logs where appended, the scheduler would constantly check for non ready buffers, consuming resources and causing the CPU to spike.

@giortzisg giortzisg requested a review from lcian November 24, 2025 14:14
@giortzisg giortzisg self-assigned this Nov 24, 2025
@giortzisg giortzisg merged commit 112f257 into master Nov 24, 2025
17 checks passed
@giortzisg giortzisg deleted the fix/scheduler branch November 24, 2025 14:26
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.78%. Comparing base (03de096) to head (7a419cf).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   86.81%   86.78%   -0.04%     
==========================================
  Files          62       62              
  Lines        6092     6092              
==========================================
- Hits         5289     5287       -2     
- Misses        589      590       +1     
- Partials      214      215       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants