Skip to content

feat: drop rate-limited events#1138

Merged
cleptric merged 3 commits intomasterfrom
feat/buffer-overflow
Nov 18, 2025
Merged

feat: drop rate-limited events#1138
cleptric merged 3 commits intomasterfrom
feat/buffer-overflow

Conversation

@giortzisg
Copy link
Contributor

Description

To avoid filling up the buffer queues when rate-limited, we should be dropping events that got selected for processing. This is a behavioral change, since both the new and old transports/scheduler were just skipping the event without dropping.

@giortzisg giortzisg requested a review from lcian November 17, 2025 16:10
@giortzisg giortzisg self-assigned this Nov 17, 2025
@giortzisg giortzisg requested a review from cleptric November 17, 2025 16:11
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.81%. Comparing base (a2066ef) to head (a363a28).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
+ Coverage   86.78%   86.81%   +0.03%     
==========================================
  Files          62       62              
  Lines        6092     6092              
==========================================
+ Hits         5287     5289       +2     
+ Misses        590      589       -1     
+ Partials      215      214       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cleptric
Copy link
Member

Should note somewhere that we need client reports for this.

@cleptric cleptric merged commit 03de096 into master Nov 18, 2025
18 checks passed
@cleptric cleptric deleted the feat/buffer-overflow branch November 18, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants