Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
+ Coverage 86.78% 86.81% +0.03%
==========================================
Files 62 62
Lines 6092 6092
==========================================
+ Hits 5287 5289 +2
+ Misses 590 589 -1
+ Partials 215 214 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cleptric
approved these changes
Nov 17, 2025
Member
|
Should note somewhere that we need client reports for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To avoid filling up the buffer queues when rate-limited, we should be dropping events that got selected for processing. This is a behavioral change, since both the new and old transports/scheduler were just skipping the event without dropping.