Skip to content

fix: check ptr value for visited exception chains#1132

Merged
giortzisg merged 1 commit intomasterfrom
fix/unhashable-error
Nov 13, 2025
Merged

fix: check ptr value for visited exception chains#1132
giortzisg merged 1 commit intomasterfrom
fix/unhashable-error

Conversation

@giortzisg
Copy link
Contributor

Description

Changing the implementation of tracking visited errors in the chain when parsing to exception groups, to use the pointer of the error if applicable, rather than trying to hash the error itself, to avoid cases where the error itself is unhashable.

Issues

@giortzisg giortzisg requested a review from lcian November 13, 2025 10:38
@giortzisg giortzisg self-assigned this Nov 13, 2025
@linear
Copy link

linear bot commented Nov 13, 2025

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.93%. Comparing base (2d82e58) to head (9154012).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   86.97%   86.93%   -0.04%     
==========================================
  Files          60       61       +1     
  Lines        5557     5558       +1     
==========================================
- Hits         4833     4832       -1     
- Misses        539      541       +2     
  Partials      185      185              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giortzisg giortzisg merged commit d131251 into master Nov 13, 2025
18 checks passed
@giortzisg giortzisg deleted the fix/unhashable-error branch November 13, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: hash of unhashable type

2 participants