Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
+ Coverage 86.67% 86.89% +0.22%
==========================================
Files 60 61 +1
Lines 6964 5557 -1407
==========================================
- Hits 6036 4829 -1207
+ Misses 743 542 -201
- Partials 185 186 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giortzisg
commented
Oct 24, 2025
slog/sentryslog.go
Outdated
|
|
||
| func (h *logHandler) Handle(ctx context.Context, record slog.Record) error { | ||
| // when logging without context, slog passes `context.Background`. Check for span existence to not overwrite the root context. | ||
| if sentry.SpanFromContext(ctx) == nil { |
Contributor
Author
There was a problem hiding this comment.
StartSpan adds the span as a context key, so it doesn't matter where it originates from, it only matters if the key exists.
lcian
reviewed
Oct 24, 2025
lcian
reviewed
Oct 24, 2025
lcian
reviewed
Oct 24, 2025
Member
lcian
left a comment
There was a problem hiding this comment.
Should we add tests for the change?
Does any other logger need to be updated with this fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues with how the context was passed on logs:
context.Background()SpanFromContextfirst and then default back toGetHubFromContext.Issues