Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
- Coverage 87.01% 86.87% -0.14%
==========================================
Files 56 57 +1
Lines 6130 6150 +20
==========================================
+ Hits 5334 5343 +9
- Misses 649 657 +8
- Partials 147 150 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sl0thentr0py
approved these changes
Oct 21, 2025
lcian
approved these changes
Oct 21, 2025
Member
lcian
left a comment
There was a problem hiding this comment.
It's unfortunate that we have to use reflection but it seems there's no better way to do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When checking for infinite recursion, there is a possibility that the error will be non comparable. In those cases we need to add a fallback to compare the error type and message to avoid panicking.
Issues