feat: properly support error capturing#1075
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
- Coverage 87.00% 86.93% -0.07%
==========================================
Files 55 57 +2
Lines 6077 6132 +55
==========================================
+ Hits 5287 5331 +44
- Misses 645 653 +8
- Partials 145 148 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lcian
reviewed
Sep 30, 2025
lcian
reviewed
Oct 1, 2025
2b77a8e to
e852a0f
Compare
lcian
approved these changes
Oct 1, 2025
02fd170 to
533a87d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for capturing all possible errors (including wrapped ones) in Go. The following changes were made:
Unwrap() []errorinterface, by parsing all errors in a dfs-like traversal.is_exception_group. In the end made the decision to only captureUnwrap() []errorerrors as exception_groups. This breaks the previous behavior of including any chained error in a group.Cause() error.maxErrorDepth
For the change to the default after a quick investigation these are some rough payload sizes based on the amount of errors that get unwrapped. Setting it to 100 since the payload sizes are not that big to cause any issues.
Built-in errors
Third-party pkg/errors
Issues
errors.Joinerrors inSetException#977.