-
-
Notifications
You must be signed in to change notification settings - Fork 221
fix: Native AOT for linux-musl-arm64
#4365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a389fe4
to
0938583
Compare
Note: [System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier is available on .NET 5+ but these Native AOT integration tests are only relevant for .NET 7+ when Native AOT was introduced.
831bdac
to
49266d7
Compare
49266d7
to
46f3953
Compare
Flash0ver
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤘 ... 2 questions and 1 nitpick
Co-authored-by: Stefan Pölz <[email protected]>
This was referenced Jul 29, 2025
Closed
This was referenced Aug 15, 2025
This was referenced Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing a minimal Alpine .NET AOT container on a Mac with Apple silicon requires
linux-musl-arm64
as brought up in:Problem: GitHub Actions hosted Node.js not available for MUSL ARM64
Node.js is required for JS actions, such as
actions/checkout
. For various reasons, GitHub Actions forces all containers to run a pre-compiled Node.js from the host, bind-mounted to the container in the/__e
(aka. "externals") directory. The problem is that there's no suitable pre-compiled version for Linux MUSL ARM64.A workaround is possible but it gets quite hacky. First of all, we need to bind-mount either
/__e/node20
or/__e/node20/bin
to "escape" the built-in/__e
bind-mount. Secondly, we need to make sure/__e/node20/bin/node
points to a working node executable. In our case, we link it to the system installation i.e./usr/bin/node
. Finally, we need to alter/etc/os-release
and pretend not to be Alpine (changeID=alpine
to anything else) to avoid the following hard-coded Alpine container compatibility check:https://github.com/actions/runner/blob/main/src/Runner.Worker/Handlers/StepHost.cs
See also: