-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add a new version of the sampling page for Python SDK 3.0 #14275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.36kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
```python | ||
sentry_sdk.start_transaction( | ||
# kwargs passed to Transaction constructor - will be recorded on transaction | ||
name="GET /search", | ||
op="search", | ||
data={ | ||
"query_params": { | ||
"animal": "dog", | ||
"type": "very good" | ||
} | ||
}, | ||
# `custom_sampling_context` - won't be recorded | ||
custom_sampling_context={ | ||
# PII | ||
"user_id": "12312012", | ||
# too big to send | ||
"search_results": { ... } | ||
} | ||
) | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the current content of the snippet in performance/custom-sampling-context
. Inlined it here so that the snippet can be updated to be 3.x compatible and used from the 3.x page.
sentry_sdk.start_transaction( | ||
name="GET /search", | ||
sampled=True | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
DESCRIBE YOUR PR
We've made some changes to sampling in the upcoming 3.0 version of the Python SDK. Creating a new 3.x version of the page.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES