Skip to content

feat(menu): Add ellipsis to cut long menu items #13769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented May 20, 2025

DESCRIBE YOUR PR

Instead of enlarging the text to two rows, long menu items get an ellipsis at the end, like here:

image

closes #13766

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 7:57am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 7:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 7:57am

Copy link

codecov bot commented May 20, 2025

Bundle Report

Changes will increase total bundle size by 43 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.2MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.51MB 52 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/css/*.css 58 bytes 18.76kB 0.31%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/S1ueN4o8tPwSDNFrCTHJb/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/S1ueN4o8tPwSDNFrCTHJb/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/_o8_8LunSgjPygDsZbMYl/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/_o8_8LunSgjPygDsZbMYl/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@s1gr1d s1gr1d merged commit ae59e33 into master May 21, 2025
13 checks passed
@s1gr1d s1gr1d deleted the sig/menu-ellipsis branch May 21, 2025 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ellipsis to long menu items
3 participants