Skip to content

Conversation

adinauer
Copy link
Member

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@adinauer adinauer requested a review from lcian May 14, 2025 13:20
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 5:17pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 14, 2025 5:17pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2025 5:17pm

Copy link

codecov bot commented May 14, 2025

Bundle Report

Changes will increase total bundle size by 2.01kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.19MB 2.02kB (0.02%) ⬆️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 675 bytes 395.93kB 0.17%
../app/platform-redirect/page.js.nft.json 675 bytes 395.85kB 0.17%
../app/sitemap.xml/route.js.nft.json 675 bytes 393.82kB 0.17%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/zfiXkK2iO4JlGnLY-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/zfiXkK2iO4JlGnLY-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/mLCO9S-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/mLCO9S-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions to improve

Comment on lines +24 to +26
## Integrations

<PlatformContent includePath="logs/integrations" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this part until we have integrations?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can either

a) keep it blank
b) link to a tracking GH issues for different integrations that people can subscribe to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this more - we should remove it for now. We can figure out how to document feature requests in the docs later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some links for JVM and a link to create an issue for Android

@lcian
Copy link
Member

lcian commented May 14, 2025

I would also like to run the snippets to test everything is working, did that for Python yesterday and uncovered a bunch of issues.
Or have you already ran all of these? @adinauer

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +24 to +26
## Integrations

<PlatformContent includePath="logs/integrations" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can either

a) keep it blank
b) link to a tracking GH issues for different integrations that people can subscribe to.

Co-authored-by: Lorenzo Cian <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>
@adinauer
Copy link
Member Author

Or have you already ran all of these?
@lcian I haven't run all of them, just copied parts from IDE and then adapted from there.

@adinauer
Copy link
Member Author

Merging now so we have docs in place. Feel free to keep reviewing. I'll send follow up PRs to improve.

@adinauer adinauer enabled auto-merge (squash) May 14, 2025 16:45
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged in #13676 - mind changing the snippets here?

Edit: Went ahead and committed the suggestions.

@codeowner-assignment codeowner-assignment bot requested a review from a team May 14, 2025 17:01
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) May 14, 2025 17:10
@AbhiPrasad AbhiPrasad merged commit 46bfce1 into master May 14, 2025
12 checks passed
@AbhiPrasad AbhiPrasad deleted the feat/java-logs branch May 14, 2025 17:17
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants