feat(native): clarifying crashpad behavior #13689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 243 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
docs/platforms/native/advanced-usage/backend-tradeoffs/index.mdx
Outdated
Show resolved
Hide resolved
JoshuaMoelans
force-pushed
the
joshua/crashpad_docker_docs
branch
from
a819d6e to
6d9e389
Compare
JoshuaMoelans
commented
May 15, 2025
docs/platforms/native/advanced-usage/container-environments/index.mdx
Outdated
Show resolved
Hide resolved
supervacuus
approved these changes
May 15, 2025
coolguyzone
reviewed
May 15, 2025
| @@ -26,6 +28,9 @@ Currently, `crashpad` is the default on all desktop platforms because it | |||
| * cooperation with Epic's Easy Anti-Cheat | |||
| * CMake build scripts (some users use our backend handler forks solely because of this reason) | |||
|
|
|||
| <Alert> | |||
| When your deployment scenario should wait for the `crashpad_handler` to finish its work before a shutdown-after-crash (systemd, Docker), in Linux environments since SDK version [0.8.3](https://github.com/getsentry/sentry-native/releases/tag/0.8.3), you can enable the [option `crashpad_wait_for_upload`](/platforms/native/configuration/options/#crashpad-wait-for-upload) to delay application shutdown until the upload of the crash report is completed. | |||
There was a problem hiding this comment.
Suggested change
| When your deployment scenario should wait for the `crashpad_handler` to finish its work before a shutdown-after-crash (systemd, Docker), in Linux environments since SDK version [0.8.3](https://github.com/getsentry/sentry-native/releases/tag/0.8.3), you can enable the [option `crashpad_wait_for_upload`](/platforms/native/configuration/options/#crashpad-wait-for-upload) to delay application shutdown until the upload of the crash report is completed. | |
| While your deployment scenario should wait for the `crashpad_handler` to finish its work before a shutdown-after-crash (systemd, Docker), in Linux environments since SDK version [0.8.3](https://github.com/getsentry/sentry-native/releases/tag/0.8.3), you can enable the [option `crashpad_wait_for_upload`](/platforms/native/configuration/options/#crashpad-wait-for-upload) to delay application shutdown until the upload of the crash report is completed. |
There was a problem hiding this comment.
Not sure about this change, I meant when as in if, since not all apps run into this problem (only when they are running in a systemd/docker env.)
coolguyzone
reviewed
May 15, 2025
docs/platforms/native/advanced-usage/container-environments/index.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
May 15, 2025
docs/platforms/native/advanced-usage/container-environments/index.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
May 15, 2025
docs/platforms/native/advanced-usage/container-environments/index.mdx
Outdated
Show resolved
Hide resolved
- avoid it showing up under "When shouldn't I use the `crashpad` backend" in docs searches
Co-authored-by: Alex Krawiec <[email protected]>
JoshuaMoelans
force-pushed
the
joshua/crashpad_docker_docs
branch
from
fffffa2 to
9d2ff88
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vercel previews
DESCRIBE YOUR PR
(from Slack)
We already have some pages that detail aspects of this, but we want to make sure this is as clear as possible:
Current changes/fixes
repositioning
wait_for_uploadline in backend tradeoffs; otherwise, search showed it under "When shouldn't I use the crashpad backend?". Also added new heading above for it to fall under.(note: search doesn't seem to update right away)
after
(this is where I'd put a screenshot of the search pointing to
Why is crashpad the default(preview) instead, but seems to not update on Vercel 🤔 )added min. version to
wait_for_uploadmentionadd docker entry point script to wait for handler (for people below 0.8.3/non-linux)
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.