Skip to content

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented May 13, 2025

DESCRIBE YOUR PR

Resolves getsentry/sentry-dotnet#3651:

Basically there are a couple of new pages under the .NET dropdown now:
image

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • [ X ] None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

cc: @bruno-garcia @Flash0ver @aritchie

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented May 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 11:17pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 11:17pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 11:17pm

Copy link

codecov bot commented May 13, 2025

Bundle Report

Changes will increase total bundle size by 345 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.19MB 351 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/HSdwMPtIJVdvaYA5QfbDK/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/HSdwMPtIJVdvaYA5QfbDK/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/pmkOCFY1p0Gunl1Lj2eQz/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/pmkOCFY1p0Gunl1Lj2eQz/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 120 bytes 394.86kB 0.03%
../app/platform-redirect/page.js.nft.json 120 bytes 394.78kB 0.03%
../app/sitemap.xml/route.js.nft.json 120 bytes 392.75kB 0.03%

Copy link
Member

@Flash0ver Flash0ver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Looks consistent:

  • docs/platforms/dotnet/guides/android/index.mdx matches platforms/android/
  • docs/platforms/dotnet/guides/apple/index.mdx matches platforms/apple/
  • the titles .NET for Android and .NET for iOS, macOS and Mac Catalyst match the titles from the Microsoft documentation

The only thing slightly off is the "double-for":
image

  • Sentry for .NET for Android
  • Sentry for .NET for iOS, macOS, and Mac Catalyst

But the titles .NET for Android and .NET for iOS, macOS and Mac Catalyst are consistent with the documentation from Microsoft, so I think this really is a non-concern.

Anyway ...
I posted a couple of questions and some thoughts about even more consistency.

@jamescrosswell jamescrosswell merged commit 350714a into master May 14, 2025
13 checks passed
@jamescrosswell jamescrosswell deleted the docs/dotnet/mobile-native branch May 14, 2025 07:29
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to initialize Sentry on native mobile apps (not MAUI)
3 participants