Skip to content

flutter v9: update snippets #13496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 16, 2025
Merged

flutter v9: update snippets #13496

merged 32 commits into from
Jun 16, 2025

Conversation

buenaflor
Copy link
Contributor

Closes getsentry/sentry-dart#2702

Do not merge until Flutter v9 is GA

@vercel Vercel
Copy link

vercel bot commented Apr 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 1:59pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 1:59pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 1:59pm

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 393 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.92MB -387 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%
../app/[[...path]]/page.js.nft.json -126 bytes 400.36kB -0.03%
../app/platform-redirect/page.js.nft.json -126 bytes 400.27kB -0.03%
../app/sitemap.xml/route.js.nft.json -126 bytes 398.24kB -0.03%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 401.83kB -0.0%
static/rAKY7Rhld-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/rAKY7Rhld-*.js (New) 616 bytes 616 bytes 100.0% 🚀
static/nrTMLpPRT8SuGEEFeJ5mP/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/nrTMLpPRT8SuGEEFeJ5mP/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@buenaflor buenaflor marked this pull request as ready for review April 24, 2025 14:47
coolguyzone
coolguyzone reviewed May 1, 2025
View reviewed changes
coolguyzone
coolguyzone approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd also recommend having a platform eng double-check all the code snippets modified here.

@buenaflor buenaflor mentioned this pull request May 12, 2025
Closed
@buenaflor buenaflor mentioned this pull request May 13, 2025
Merged
kahest
kahest approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codeowner-assignment codeowner-assignment bot requested a review from a team May 14, 2025 12:07
@buenaflor buenaflor enabled auto-merge (squash) June 16, 2025 13:24
@buenaflor buenaflor merged commit 37890a8 into master Jun 16, 2025
12 checks passed
@buenaflor buenaflor deleted the buenaflor/v9-update-snippets branch June 16, 2025 13:59
antonpirker pushed a commit that referenced this pull request Jun 24, 2025
@buenaflor @coolguyzone @antonpirker
flutter v9: update snippets (#13496)
67b983e 
Closes getsentry/sentry-dart#2702

Do not merge until Flutter v9 is GA

---------

Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kahest kahest kahest approved these changes

@coolguyzone coolguyzone coolguyzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v9]: Update docs on removed fields and update experimental features such as replay
3 participants
@buenaflor @kahest @coolguyzone