-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(React Native) Add react native V7 migration #13025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Co-authored-by: Antonis Lilis <[email protected]>
Bundle ReportChanges will increase total bundle size by 180 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Co-authored-by: Antonis Lilis <[email protected]>
Hey @lucas-zimerman , is this PR still a thing? If it's ready for review can you remove the 'Draft' label, or close it if we don't want to merge? |
It is, I took some time to revise any additional changes and now it's ready for review |
Thanks for the fix @krystofwoldrich on the diff! Before I had to add that odd spacing to align it. |
@coolguyzone Could you give this one more review, we have added a few new sections. After a final review we can merge this. The RN SDK v7 beta is out so this will be helpful for Sentry's early adopters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added a few minor suggestions, thanks for adding 🏄♂️
Co-authored-by: Alex Krawiec <[email protected]>
Thank you for the reviews! |
DESCRIBE YOUR PR
This PR adds the migration guide to React Native V7.
Since a final version isn't released, I added a warning mentioning that the migration guide can change while a final release isn't made
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
EXTRA RESOURCES