Skip to content

feat(React Native) Add react native V7 migration #13025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 13, 2025
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Mar 17, 2025

DESCRIBE YOUR PR

This PR adds the migration guide to React Native V7.

Since a final version isn't released, I added a warning mentioning that the migration guide can change while a final release isn't made

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

EXTRA RESOURCES

Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 3:52pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 3:52pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 3:52pm

Copy link

codecov bot commented Mar 19, 2025

Bundle Report

Changes will increase total bundle size by 180 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.22MB 186 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/d9zZKD-*.js (New) 616 bytes 616 bytes 100.0% 🚀
static/d9zZKD-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/PD1DhxccGEkoNa8zHGAsH/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/PD1DhxccGEkoNa8zHGAsH/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 65 bytes 398.93kB 0.02%
../app/platform-redirect/page.js.nft.json 65 bytes 398.85kB 0.02%
../app/sitemap.xml/route.js.nft.json 65 bytes 396.82kB 0.02%

@antonis antonis self-requested a review March 21, 2025 07:22
@coolguyzone
Copy link
Contributor

Hey @lucas-zimerman , is this PR still a thing? If it's ready for review can you remove the 'Draft' label, or close it if we don't want to merge?

@lucas-zimerman
Copy link
Collaborator Author

Hey @lucas-zimerman , is this PR still a thing? If it's ready for review can you remove the 'Draft' label, or close it if we don't want to merge?

It is, I took some time to revise any additional changes and now it's ready for review

@lucas-zimerman
Copy link
Collaborator Author

Thanks for the fix @krystofwoldrich on the diff! Before I had to add that odd spacing to align it.

@krystofwoldrich
Copy link
Contributor

@coolguyzone Could you give this one more review, we have added a few new sections.

After a final review we can merge this.

The RN SDK v7 beta is out so this will be helpful for Sentry's early adopters.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a few minor suggestions, thanks for adding 🏄‍♂️

@lucas-zimerman
Copy link
Collaborator Author

Thank you for the reviews!

@lucas-zimerman lucas-zimerman merged commit 8a7ce86 into master Jun 13, 2025
12 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/rn7-migration branch June 13, 2025 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants