Skip to content

Move Isolate-related exports to sentry_io.dart #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Move Isolate-related exports to sentry_io.dart #1371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea5974b
Move Isolate-related exports to sentry_io.dart
mnordine Mar 30, 2023
9840646
Add changelog entry documenting Isolate changes
mnordine Mar 31, 2023
33a8217
Update CHANGELOG.md
marandaneto Mar 31, 2023
aebb1fb
Merge branch 'main' into web-fix
marandaneto Mar 31, 2023
f68ed0a
Update CHANGELOG.md
marandaneto Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## Unreleased

### Fixes

- Fix Dart web builds breaking due to `dart:io` imports when using `SentryIsolate` or `SentryIsolateExtension` ([#1371](https://github.com/getsentry/sentry-dart/pull/1371))
- When using `SentryIsolate` or `SentryIsolateExtension`, import `sentry_io.dart`.

## 7.4.0

### Features
Expand Down
3 changes: 0 additions & 3 deletions dart/lib/sentry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ export 'src/type_check_hint.dart';
export 'src/exception_cause_extractor.dart';
export 'src/exception_cause.dart';
export 'src/exception_stacktrace_extractor.dart';
// Isolates
export 'src/sentry_isolate_extension.dart';
export 'src/sentry_isolate.dart';
// URL
// ignore: invalid_export_of_internal_element
export 'src/utils/http_sanitizer.dart';
Expand Down
3 changes: 3 additions & 0 deletions dart/lib/sentry_io.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// ignore: invalid_export_of_internal_element
export 'sentry.dart';
export 'src/sentry_attachment/io_sentry_attachment.dart';
// Isolates
export 'src/sentry_isolate_extension.dart';
export 'src/sentry_isolate.dart';