Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Allow configuration from environment variables #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianyamey
Copy link

@ianyamey ianyamey commented Aug 31, 2016

Allows configuration of the GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET using Environment Variables


This change is Reviewable

Allows configuration of the GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET using Environment Variables
@dcramer
Copy link
Member

dcramer commented Aug 31, 2016

I'd rather this be supported via sentry.options. Environment variables are problematic for various reasons, and we're never going to support "configure everything with env vars".

@ianyamey
Copy link
Author

ianyamey commented Sep 1, 2016

@dcramer, no problem. Can you point me to an example of sentry.options or elaborate on your suggested approach?

@dcramer
Copy link
Member

dcramer commented Sep 1, 2016

Best bet is to look in sentrys code on GitHub. src/sentry/options. Specifically you need .register and .get.  We also don't have a way to expose these via web UI yet but they could still be set with CLI. 

On Thu, Sep 1, 2016 at 6:38 AM -0700, "Ian Yamey" [email protected] wrote:

@dcramer, no problem. Can you point me to an example of sentry.options or elaborate on your suggested approach?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants