fix(server): Fix deserialization errors on unknown item headers#5709
Merged
fix(server): Fix deserialization errors on unknown item headers#5709
Conversation
Dav1dde
force-pushed
the
dav1d/fix-unknown-item-headers
branch
from
4a2c8b0 to
cea96b9
Compare
tobias-wilfert
approved these changes
Mar 9, 2026
Member
tobias-wilfert
left a comment
tobias-wilfert
left a comment
There was a problem hiding this comment.
Don't fully understand why the Other(String) did not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke it in #5671, not realizing the
Unknowndoesn't work.Relay needs to accept unknown item headers, because of old SDKs, but also future SDKs.