feat(statsd): Add sampling parameter to distribution metrics#5576
feat(statsd): Add sampling parameter to distribution metrics#5576
Conversation
…er metrics
The `metric!(distribution(...))` and `metric!(timer(...))` macros now support
an optional `sampling` parameter to explicitly set a per-metric sampling rate
that overrides the global sample rate.
Example usage:
```rust
// Uses global sample rate (default behavior, unchanged)
metric!(distribution(MyMetric) = value);
metric!(timer(MyTimer) = duration);
// Override with explicit sample rate
metric!(distribution(MyMetric, sampling = 0.01) = value);
metric!(timer(MyTimer, sampling = 0.01) = duration);
metric!(timer(MyTimer, sampling = 0.01), { block });
```
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jjbayer
force-pushed
the
feat/distribution-sampling-rate
branch
from
8581a4f to
24862d6
Compare
jjbayer
changed the title
This reverts commit 07b5003.
relay-statsd/src/lib.rs
Outdated
| pub fn send_metric_with_sample_rate<'a, T>( | ||
| &'a self, | ||
| mut metric: MetricBuilder<'a, '_, T>, | ||
| sample_rate: Option<f64>, |
There was a problem hiding this comment.
Unfortunately we cannot inspect MetricBuilder to check whether a sample rate was set, so we have to pass it explicitly.
| Self::InMemory(buffer) => buffer.push(envelope).await, | ||
| }?; | ||
| relay_statsd::metric!( | ||
| distribution(RelayDistributions::BufferEnvelopeBodySize, sample = 0.01) = |
There was a problem hiding this comment.
I reverted the temporary change of #5571 and set a sample rate instead.
relay-statsd/src/lib.rs
Outdated
| pub fn send_metric_with_sample_rate<'a, T>( | ||
| &'a self, | ||
| mut metric: MetricBuilder<'a, '_, T>, | ||
| sample_rate: Option<f64>, |
There was a problem hiding this comment.
Any specific reason you went with f64 over f32 which is used for the config?
There was a problem hiding this comment.
f64 is what cadence expects, that's all (self.sample_rate gets converted to f64 down below).
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
3 participants
The
metric!(distribution(...))andmetric!(timer(...))macros now take an optionalsampleparameter to explicitly set the sampling rate the metric. This allows per-metric control over sampling rates via cadence'swith_sampling_rate.Example usage:
ref: INGEST-659