ref(spanv2): Drop span kind as a top level field#5368
Merged
Conversation
Dav1dde
force-pushed
the
dav1d/rm-spanv2-kind
branch
from
ab2808e to
143d52b
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
approved these changes
Nov 11, 2025
Dav1dde
force-pushed
the
dav1d/rm-spanv2-kind
branch
2 times, most recently
from
6f0f3de to
31c8c02
Compare
Member
Author
|
@untitaker jfyi, removal of the top level |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/rm-spanv2-kind
branch
from
31c8c02 to
79946bd
Compare
Dav1dde
force-pushed
the
dav1d/rm-spanv2-kind
branch
from
79946bd to
aa43157
Compare
cleptric
approved these changes
Nov 11, 2025
jjbayer
approved these changes
Nov 11, 2025
Lms24
approved these changes
Nov 12, 2025
Dav1dde
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 13, 2025
The field is no longer part of the Schema, Relay extracts it to an attribute already for Transaction and OTLP Spans. Relay: getsentry/relay#5368 Schema: getsentry/sentry-kafka-schemas#457 No more usages of Span Kind: ``` ┌─── [🐍.venv] src/sentry/spans <dav1d/rm-span-kind> └─ % rg kind buffer.py 58: * span-buf:z:* -- the actual set keys, containing span payloads. Each key contains all data for a segment. The most memory-intensive kind of key. consumers/process_segments/enrichment.py 216: Check the measurements on the span to determine what kind of start type the ``` Closes: INGEST-631
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the kind as a top level field from a SpanV2 span. Instead merges it into the attribute
sentry.kindwhere the buffer previously would extract it to.The schema already lists the attribute as optional.
In a follow-up:
sentry.kindto conventionsRefs: INGEST-631