feat(spans): Map span.status unknown_error to internal_error#5202
Merged
obostjancic merged 5 commits intomasterfrom Oct 7, 2025
Merged
feat(spans): Map span.status unknown_error to internal_error#5202obostjancic merged 5 commits intomasterfrom
obostjancic merged 5 commits intomasterfrom
Conversation
obostjancic
changed the title
unknown and unknown_error span status
obostjancic
force-pushed
the
ogi/feat/unknown-error-internal-error
branch
from
912ae54 to
8431a1b
Compare
obostjancic
changed the title
unknown and unknown_error span status
Dav1dde
approved these changes
Oct 7, 2025
Member
|
@obostjancic should also make a small changelog entry. |
obostjancic
changed the title
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: both span.status
unknown_errorandunknowngot mapped tounknownAfter:
unknown_errorgets mapped tointernal_errorunknownremainsunknownReasoning:
Current state makes it impossible for product to differentiate between spans that had an unknown error, and spans whose status is unknown. This makes it clear that some error occurred.