Skip to content

build: Update opentelemetry-proto to 0.7.0 #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Sep 5, 2024

Updates the opentelemetry-proto dependency to the latest version. This changes
the serde deserializer for integers from numbers to strings. This means for
intValue and all timestamp fields, the client has to send strings now. See
updated tests for examples.

#skip-changelog

@jan-auer jan-auer requested a review from a team as a code owner September 5, 2024 11:32
@jan-auer jan-auer requested review from phacops and cleptric September 5, 2024 11:32
@jan-auer jan-auer self-assigned this Sep 5, 2024
@jan-auer
Copy link
Member Author

jan-auer commented Sep 5, 2024

@cleptric there are more approaches I'd like to explore. Leaving the choice to you as I'd like SDK teams to own this portion:

  1. we can pull the protobuf files and generate our own types (using prost) but without the tonic dependency
  2. we vendor the types entirely without proto definitions. This means we need to sync updates manually, however.
  3. No change, keep the opentelemetry-proto crate

@jan-auer jan-auer force-pushed the build/opentelemetry-proto-0.7.0 branch from b313c3a to 5701f44 Compare September 5, 2024 11:35
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that all the standalone spans that SDKs currently send use the sentry format, not the Otel format, this should be fine.

@jan-auer
Copy link
Member Author

jan-auer commented Sep 5, 2024

@cleptric I'm going to merge this as-is so I can move forward with dependency cleanup. Let's follow up with your preference at your convenience.

@jan-auer jan-auer enabled auto-merge (squash) September 5, 2024 20:09
@cleptric
Copy link
Member

cleptric commented Sep 5, 2024

I feel like 1) and putting this into https://github.com/getsentry/sentry-protos. I rather not make us rely on Otel. The SDKs will maintain their own schema, so we have full control and can make changes and updates as we please.

@jan-auer jan-auer merged commit 29ecc0f into master Sep 5, 2024
23 checks passed
@jan-auer jan-auer deleted the build/opentelemetry-proto-0.7.0 branch September 5, 2024 21:13
jan-auer added a commit that referenced this pull request Sep 6, 2024
* master: (27 commits)
  build: Update dialoguer and hostname (#4009)
  build: Update opentelemetry-proto to 0.7.0 (#4000)
  build: Update lru to 0.12.4 (#4008)
  build: Update cookie to 0.18.1 (#4007)
  feat(spans): Extract standalone CLS span metrics and performance score (#3988)
  build: Update cadence to 1.4.0 and statsdproxy to 0.2.0 (#4005)
  build: Update maxminddb to 0.24.0 (#4003)
  build: Update multer to 3.1.0 (#4002)
  build: Update regex and aho-corasick (#4001)
  build: Update sentry-kafka-schemas to 1.0.107 (#3999)
  build: Update dev-dependencies (#3998)
  build: Update itertools to 0.13.0 (#3993)
  build: Update brotli, zstd, flate2 (#3996)
  build: Update rdkafka to 0.36.2 (#3995)
  build: Update tikv-jemallocator to 0.6.0 (#3994)
  build: Update minidump to 0.22.0 (#3992)
  build: Update bindgen to 0.70.1 (#3991)
  build: Update chrono to 0.4.38 (#3990)
  feat(spans): initial MongoDB description scrubbing support (#3912)
  fix(spooler): Reduce number of disk reads (#3983)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants