-
Notifications
You must be signed in to change notification settings - Fork 101
build: Update opentelemetry-proto to 0.7.0 #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cleptric there are more approaches I'd like to explore. Leaving the choice to you as I'd like SDK teams to own this portion:
|
b313c3a
to
5701f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that all the standalone spans that SDKs currently send use the sentry format, not the Otel format, this should be fine.
@cleptric I'm going to merge this as-is so I can move forward with dependency cleanup. Let's follow up with your preference at your convenience. |
I feel like 1) and putting this into https://github.com/getsentry/sentry-protos. I rather not make us rely on Otel. The SDKs will maintain their own schema, so we have full control and can make changes and updates as we please. |
* master: (27 commits) build: Update dialoguer and hostname (#4009) build: Update opentelemetry-proto to 0.7.0 (#4000) build: Update lru to 0.12.4 (#4008) build: Update cookie to 0.18.1 (#4007) feat(spans): Extract standalone CLS span metrics and performance score (#3988) build: Update cadence to 1.4.0 and statsdproxy to 0.2.0 (#4005) build: Update maxminddb to 0.24.0 (#4003) build: Update multer to 3.1.0 (#4002) build: Update regex and aho-corasick (#4001) build: Update sentry-kafka-schemas to 1.0.107 (#3999) build: Update dev-dependencies (#3998) build: Update itertools to 0.13.0 (#3993) build: Update brotli, zstd, flate2 (#3996) build: Update rdkafka to 0.36.2 (#3995) build: Update tikv-jemallocator to 0.6.0 (#3994) build: Update minidump to 0.22.0 (#3992) build: Update bindgen to 0.70.1 (#3991) build: Update chrono to 0.4.38 (#3990) feat(spans): initial MongoDB description scrubbing support (#3912) fix(spooler): Reduce number of disk reads (#3983) ...
Updates the
opentelemetry-proto
dependency to the latest version. This changesthe serde deserializer for integers from numbers to strings. This means for
intValue
and all timestamp fields, the client has to send strings now. Seeupdated tests for examples.
#skip-changelog