Skip to content

[4 lines PR] Fix: saving empty query with auto limit crashes #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eradman merged 2 commits into from
May 20, 2025
Merged

[4 lines PR] Fix: saving empty query with auto limit crashes #7430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fff9d47
Fix: saving empty query with auto limit crashes
yoshiokatsuneo May 2, 2025
71d6d7a
Merge branch 'master' into fix/saving_empty_query_with_auto_limit_crash
eradman May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion redash/query_runner/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,10 @@ def supports_auto_limit(self):
return True

def query_is_select_no_limit(self, query):
parsed_query = sqlparse.parse(query)[0]
parsed_query_list = sqlparse.parse(query)
if len(parsed_query_list) == 0:
return False
parsed_query = parsed_query_list[0]
last_keyword_idx = find_last_keyword_idx(parsed_query)
# Either invalid query or query that is not select
if last_keyword_idx == -1 or parsed_query.tokens[0].value.upper() != "SELECT":
Expand Down
Loading