Add NULLS LAST option for query list ordering #7341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiokatsuneo
changed the title
yoshiokatsuneo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Before this PR, query list ordering does not have "NULLS LAST" option.
So, when I sort query list by "Last Executed At" in descendant order to see the recent active queries, I got bunch of queries that is not executed at all and "executed_at" is null in the beginning of the list.
This happens because PostgreSQL handles NULL as the "largest value" for ordering.
I think the behavior does not make sense.
This PR fix the issue by adding "NULLS LAST" options for ordering so that the most recent query comes first, instead of query that was never run comes first.
How is this tested?
Before this PR:
After this PR:
