Change autocomplete token limit to 1000000

[yoshiokatsuneo]

What type of PR is this?

• Feature

Description

Before this PR, autocomplete is disabled for tokens more than 5000. That is too small for us, and probably the most of dataware house.

And, anyway, each user can disable autocomplete if they want.
I think it should be up to user to decide whether to use autocomplete or not, and it is better to make hard-coded limit large enough to most user.

This PR changes the limit of the token from 5000 to 1000000. There is no change on memory consumption as the tokens are anyway stored on memory even if autocomplete is disabled.

How is this tested?

• Manually

I confirmed that there is no problem for token more than 700000, and there is no CPU/memory exhausting.

[denisov-vlad]

Great! Did the same for my Redash instance.

[eradman]

This PR changes the limit of the token from 5000 to 1000000. There is no change on memory consumption as the tokens are anyway stored on memory even if autocomplete is disabled.

This is a good point! Should this check be removed altogether?

[yoshiokatsuneo]

This PR changes the limit of the token from 5000 to 1000000. There is no change on memory consumption as the tokens are anyway stored on memory even if autocomplete is disabled.

This is a good point! Should this check be removed altogether?

@eradman

Sounds like a plan !
I just made another PR that remove the check altogether.

#7326

[eradman]

Closing in favor of #7326