Create workflow trigger for publishing release image #7259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucydodo
reviewed
Dec 25, 2024
Member
lucydodo
left a comment
lucydodo
left a comment
There was a problem hiding this comment.
It looks good, but it seems like you might have forgotten to change the username back after testing. 🤔
- If the action was not triggered manually, publish a preview image - Always select a branch for release image
eradman
force-pushed
the
release-image
branch
from
2bb3770 to
7457c43
Compare
justinclift
approved these changes
Dec 27, 2024
Member
justinclift
left a comment
justinclift
left a comment
There was a problem hiding this comment.
With that repo name fixed, this looks good to merge. 😄
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Justin Clift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
How is this tested?
Tested on personal Dockerhub account
https://hub.docker.com/repository/docker/eradman/redash/general
https://hub.docker.com/repository/docker/eradman/preview/general
Related Tickets & Documents
#7251
Preview image from master
Publish a release