Change: send events to webhook as JSON with a schema.#1563
Merged
Conversation
Member
Author
|
@alexanderdean there are two changes here from your schema:
|
|
Sounds good @arikfr - I've added snowplow/iglu-central#484 Snowplow can't (yet) deduplicate webhook events based on webhook-specific fields, so no rush to add in an event |
|
Not a deal-breaker but I would probably emit the It's slightly more compact, and less brittle - the TZ of the instance running Redash shouldn't be significant at analytics time... |
Member
Author
|
In most deployments the server time will be UTC anyway. I'll change it to be UTC regardless, but I guess it's less urgent. |
|
Makes sense - thanks @arikfr ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of resulting event:
{ "data":{ "user_id":null, "created_at":"2017-02-02T08:08:15+02:00", "object_type":"test", "org_id":1, "object_id":null, "additional_properties":{ "test":1 }, "action":"test" }, "schema":"iglu:io.redash.webhooks/event/jsonschema/1-0-0" }Closes #1552.