Added global params to dashboards#1483
Closed
rockwotj wants to merge 1 commit intogetredash:masterfrom
Closed
Conversation
Contributor
Author
|
There needs to be some way to update the global params list when a widget is added or removed. Any thoughts on this? Should there be a watch on the length of widgets? |
Member
|
Watch on widgets will work, although it's bad for performance. On the master branch, you can just do this in a callback after the add widget dialog is closed. |
Contributor
Author
|
SG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think master is currently in a broken state, so I couldn't actually make this change there, but I did start from the last release
v0.12.0.b2449and made this change. I can't propose a PR from a tag or propose a new branch though.If you prefix a parameter with
$then when viewing it at the dashboard level it gets promoted to be a dashboard level param and queries can share these params.Feature request here: https://discuss.redash.io/t/add-ui-for-query-params-at-dashboard-level/236/8
Video of the feature here: https://goo.gl/photos/UEjDv3fDhCrb2AnU6
I guess in order to merge this, we'd need a new branch for a
v0.13.0release or something similar. When master is stable and I would be more than happy to add this there too (and make it slightly less hacky). Our team needs this to adopt redash, and we don't want to be stuck on an old version 😄