properly handle view_only permission in groups API#1418
Closed
washort wants to merge 1 commit intogetredash:masterfrom
Closed
properly handle view_only permission in groups API#1418washort wants to merge 1 commit intogetredash:masterfrom
washort wants to merge 1 commit intogetredash:masterfrom
Conversation
arikfr
reviewed
Nov 21, 2016
| if with_permissions: | ||
| d['view_only'] = self.data_source_groups.view_only | ||
| if with_permissions_for is not None: | ||
| d['view_only'] = DataSourceGroup.get( |
Member
There was a problem hiding this comment.
This way we need to make another database query, while we already have the object from calling add_group/remove_group. How about we change those methods to return the DataSourceGroup object, and then assign the view_only value in the handler code?
Member
|
Implemented in #1417. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up an oversight in
DataSource.to_dict.