refact: Kirby\Auth\Limits
#7835
Open
+442
−242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
v6/refact/auth-limits
branch
from
3ec9625 to
1055d8a
Compare
distantnative
force-pushed
the
v6/refact/auth-limits
branch
3 times, most recently
from
f5cde23 to
91385d7
Compare
distantnative
force-pushed
the
v6/refact/auth-limits
branch
from
91385d7 to
6ffde3f
Compare
distantnative
force-pushed
the
v6/refact/auth-limits
branch
from
503311e to
69972d8
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a new namespace
Kirby\Authwhere we will create all future auth-related classes. And eventually move the existing auth classes there.Starting with a
Limitsclass to pull out the rate-limiting logic out of theAuthclass.Changelog
♻️ Refactored
Kirby\Auth\LimitsclassKirby\Auth\Exception\RateLimitException☠️ Deprecated
Kirby\Cms\Auth::checkRateLimit(),Kirby\Cms\Auth::isBlocked(),Kirby\Cms\Auth::log(),Kirby\Cms\Auth::logfile()andKirby\Cms\Auth::track()have been deprecated. use$auth->limits()and the respective method.For review team